Add an example, link it in the README #219
Merged
+603
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
reviewed
Jul 14, 2022
There was a problem hiding this comment.
LGTM, but there is another reference to test.NewServer in examples/tracing/trace_test.go that is passing in an argument. See: https://github.com/lightstep/otel-launcher-go/pull/219/files#file-examples-tracing-trace_test-go-L27.
added 2 commits
July 14, 2022 23:26
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 62 62
Lines 3312 3312
=======================================
Hits 3122 3122
Misses 145 145
Partials 45 45
Continue to review full report at Codecov.
|
|
Fixed, PTAL. |
jaronoff97
reviewed
Jul 18, 2022
jaronoff97
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add an example to test the smallest configuration of the Lightstep metrics SDK for stand-alone use.
Testing: This is a test.
Documentation: Linked from README.md